bazel: Migrate to bazel 7; use bzlmod for dependencies #293
Conversation
MODULE.bazel
Outdated
| llvm_version = "13.0.0", | ||
| ) | ||
| use_repo(llvm, "llvm_toolchain") | ||
| register_toolchains("@llvm_toolchain//:all", dev_dependency = True) |
There was a problem hiding this comment.
this version doesn't support macOS, excluding it just replies on the host having a CC toolchain installed, we could probably bring this back with a different version to support macOS too but I think the norm is normally to expect the host to have something for this
| @@ -0,0 +1,29 @@ | |||
| module( | |||
| name = "remoteapis", | |||
There was a problem hiding this comment.
Shall it be this instead ?
| name = "remoteapis", | |
| name = "remote-apis", | |
| repo_name = "bazel_remote_apis", |
There was a problem hiding this comment.
i pulled the non-dash version because that's what bazel uses, any precedent for folks using the other one? I didn't need to mirror the repo_name since it's never accessed
|
Any idea when this will be merged? This would improve the reclient MODULE.bazel and make it easier to migrate remote-apis-sdks to bzlmod |
|
I let this sit for far too long, resulting in a second PR for converting to bzlmod (#307). I ended up merging that one instead, simply because it was more recent. I did like the idea of a sample project from this PR--feel free to rebase and send a PR with just the sample project changes. |
This is based on #284 with a few more minor bzlmod fixes
This depends on bazelbuild/bazel-central-registry#1699